Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template cisco_ios_show_snmp_user.template #429

Merged
merged 8 commits into from
Jul 26, 2019
Merged

New template cisco_ios_show_snmp_user.template #429

merged 8 commits into from
Jul 26, 2019

Conversation

jifox
Copy link
Contributor

@jifox jifox commented Jul 21, 2019

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_ios_show_snmp_user.template

SUMMARY

see issue #390

Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jifox Thanks for getting this submitted! We're lacking a few things that are touched on the README for contributing. Do you mind modifying the index file and put the template in the correct order and then add a .raw and .parsed to the test directory?

The directory would be tests/cisco_ios/show_snmp_user/ and they would be named cisco_ios_show_snmp_user1.raw. You can just put the .raw in there and then run the helper playbook in ./helpers and it'll generate the .parsed file for you. It does require Ansible and ntc-ansible.

If you're on our community Slack, you can join the #networktocode channel and ask for help or PM me directly for help.

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Jul 21, 2019
@jifox
Copy link
Contributor Author

jifox commented Jul 22, 2019

@FragmentedPacket
Implemented sugested changes

@FragmentedPacket FragmentedPacket self-requested a review July 22, 2019 21:36
Value Required USER_NAME (\w+)
Value ENGINE_ID (\w+)
Value STORAGE_TYPE (\w+)
Value STORAGE_TYPE_ACTIVE (\w+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the STORAGE_TYPE_ACTIVE to ACCESS_LIST to capture d+ as that appears from the Cisco docs as to what it is referring to:

https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/snmp/command/nm-snmp-cr-book/nm-snmp-cr-s1.html#wp8434359780

And then change L12 to:
^storage-type:\s${STORAGE_TYPE}\s+active$$

And add the following line right above:
^storage-type:\s${STORAGE_TYPE}\s+active\s+access-list:\s+${ACCESS_LIST}$$

@jifox
Copy link
Contributor Author

jifox commented Jul 26, 2019

@FragmentedPacket
Suggested changes are implemneted. Raw data modified to reflect the access_list parameter.

@FragmentedPacket FragmentedPacket merged commit 4225a04 into networktocode:master Jul 26, 2019
@jifox jifox deleted the cisco_ios_show_snmp_user branch July 28, 2019 03:26
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
New template: cisco_ios_show_snmp_user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants