fixed ports #471
Merged
fixed ports #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
@dainok Thanks for your submission!
Do you mind adding new raw and parsed files for your use case and leave the original's unchanged. This allows more test data and ensure backwards compatibility.
After that and the tests pass, we can merge this.
FragmentedPacket
added
bug
changes_requested
FragmentedPacket
approved these changes
Sep 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
hp_procurve_show_arp
SUMMARY
Fix to support incomplete ARP and non digit ports (like trunks)