-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 472 patch #479
Merged
FragmentedPacket
merged 16 commits into
networktocode:master
from
mullaneywt:issue-472-patch
Sep 29, 2019
Merged
Issue 472 patch #479
FragmentedPacket
merged 16 commits into
networktocode:master
from
mullaneywt:issue-472-patch
Sep 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in the ipv4 version of the ipv6 command "sh ip interface brief" for NXOS. This already existed for IPv6, and for IPv4 in Cisco IOS. Note: "int" works in this command, "interf" is not required.
FragmentedPacket
suggested changes
Sep 29, 2019
@@ -0,0 +1,662 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be removed. Appears to have the data from cisco_nxos_show_interface_brief
FragmentedPacket
added
bug
changes_requested
Waiting on user to address feedback
labels
Sep 29, 2019
Update from origin
Clean up files from master
FragmentedPacket
approved these changes
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_nxos_show_interface_brief
SUMMARY
Updated the cisco_nxos_show_interface_brief template to include additional mode types pvlan and fabric as requested in issue #472. Includes new raw file and parsed test output.
Fixes #472