Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Values for route-map names fetch for nxos_sh_ip_bgp_nei #481

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Adding Values for route-map names fetch for nxos_sh_ip_bgp_nei #481

merged 2 commits into from
Oct 7, 2019

Conversation

nnaukwal
Copy link
Contributor

@nnaukwal nnaukwal commented Oct 2, 2019

ISSUE TYPE
  • Update Existing Template Pull Request
COMPONENT
  • cisco_nxos_show_ip_bgp_neighbors.template
SUMMARY

The change adds "inbound_routemap / outbound_routemap" keys to the existing "cisco_nxos_show_ip_bgp_neighbors.template" template. The intention is to fetch the names of the route-maps, applied in INBOUND/OUTBOUND direction, to a given BGP peer, and then further use it for network validations/audits.

TESTING
nnaukwal/ntc-templates$ tox
collected 386 items
<snip>
tests/test_structured_data_against_parsed_reference_files.py::test_raw_data_against_mock[tests/cisco_nxos/show_ip_bgp_neighbors/cisco_nxos_show_ip_bgp_neighbors_with_policy_names.raw] PASSED                             [ 92%]
tests/test_structured_data_against_parsed_reference_files.py::test_raw_data_against_mock[tests/cisco_nxos/show_ip_bgp_neighbors/cisco_nxos_show_ip_bgp_neighbors.raw] PASSED                                               [ 92%]
<snip>
__ summary __
  py35: commands succeeded
  congratulations :)
Before:
- accepted_paths: '38'
  addr_fam_adv: 'IPv4 Unicast  '
  addr_fam_rcv: ''
  addr_family: [IPv4 Unicast]
  asn: '64514'
  bgp_state: Established
  capability_count_rcvd: '0'
  capability_count_sent: '0'
  conn_dropped: '12'
  conn_estab: '13'
  consumed_mem: '2128'
  description: ''
  ext_nh_cap: advertised received
  fourbyte_cap: 'advertised received '
  graceful_cap: advertised received
  keepalives_count_rcvd: '668381'
  keepalives_count_sent: '668251'
  last_peer_reset: never
  last_peer_reset_reason: No error
  last_reset: 2d21h
  last_reset_reason: bfd session down
  localhost_ip: 10.20.0.1
  localhost_port: '61055'
  nei_table_version: ['9396']
  neighbor: 10.20.0.2
  notifications_count_rcvd: '0'
  notifications_count_sent: '0'
  opens_count_rcvd: '58'
  opens_count_sent: '13'
  remote_ip: 10.20.0.2
  remote_port: '179'
  restart_time_adv: '120'
  restart_time_rcv: '120'
  route_refresh_count_rcvd: '2'
  route_refresh_count_sent: '0'
  rr_new_cap: 'advertised received '
  rr_old_cap: 'advertised received '
  sent_paths: '59'
  source_iface: Ethernet1/6
  stale_time: '300'
  table_version: ['9396']
  total_bytes_count_rcvd: '12704086'
  total_bytes_count_sent: '12748983'
  total_bytes_rcvd_queue: '0'
  total_bytes_send_queue: '0'
  total_mess_count_rcvd: '668454'
  total_mess_count_sent: '668840'
  updates_count_rcvd: ''
  updates_count_sent: '576'
  uptime: 2d21h

After:
- accepted_paths: '38'  
  addr_fam_adv: 'IPv4 Unicast  '  
  addr_fam_rcv: ''  
  addr_family:  [IPv4 Unicast]
  asn: '64514'
  bgp_state: Established
  capability_count_rcvd: '0'
  capability_count_sent: '0'
  conn_dropped: '12'
  conn_estab: '13'
  consumed_mem: '2128'
  description: ''
  ext_nh_cap: advertised received
  fourbyte_cap: 'advertised received '
  graceful_cap: advertised received
  inbound_routemap: RM-GTT-IN     <<<<<
  keepalives_count_rcvd: '668429'
  keepalives_count_sent: '668298'
  last_peer_reset: never
  last_peer_reset_reason: No error
  last_reset: 2d21h
  last_reset_reason: bfd session down
  localhost_ip: 10.20.0.1
  localhost_port: '61055'
  nei_table_version: ['9396']
  neighbor: 10.20.0.2
  notifications_count_rcvd: '0'
  notifications_count_sent: '0'
  opens_count_rcvd: '58'
  opens_count_sent: '13'
  outbound_routemap: RM-GTT-OUT   <<<<<
  remote_ip: 10.20.0.2
  remote_port: '179'
  restart_time_adv: '120'
  restart_time_rcv: '120'
  route_refresh_count_rcvd: '2'
  route_refresh_count_sent: '0'
  rr_new_cap: 'advertised received '
  rr_old_cap: 'advertised received '
  sent_paths: '59'
  source_iface: Ethernet1/6
  stale_time: '300'
  table_version: ['9396']
  total_bytes_count_rcvd: '12704998'
  total_bytes_count_sent: '12749876'
  total_bytes_rcvd_queue: '0'
  total_bytes_send_queue: '0'
  total_mess_count_rcvd: '668502'
  total_mess_count_sent: '668887'
  updates_count_rcvd: ''
  updates_count_sent: '576'
  uptime: 2d21h

@FragmentedPacket FragmentedPacket added changes_requested Waiting on user to address feedback enhancement labels Oct 7, 2019
@FragmentedPacket FragmentedPacket merged commit 7fc09b6 into networktocode:master Oct 7, 2019
@nnaukwal nnaukwal deleted the nxos_bgp_nei branch October 7, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants