Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 537 - IOS show interfaces switchport - Changed output #538

Merged
merged 8 commits into from
Nov 11, 2019
Merged

Fixes 537 - IOS show interfaces switchport - Changed output #538

merged 8 commits into from
Nov 11, 2019

Conversation

FragmentedPacket
Copy link
Contributor

@FragmentedPacket FragmentedPacket commented Nov 10, 2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_interfaces_switchport.template

SUMMARY

Fixes #537
Cisco has added additional output that needs to be accounted for:

Unknown unicast blocked: disabled
Unknown multicast blocked: disabled

The updates prevent the template from failing

@vnetman
Copy link

vnetman commented Nov 11, 2019

OK, I verified it and it works.

But shouldn't the fix be ^\s*Unknown\s+(unicast|multicast) instead of ^\s*Unknown\s+[unicast|multicast] (i.e. round brackets instead of square brackets)? I tried that, and that also works.

@vnetman
Copy link

vnetman commented Nov 11, 2019

By the way, the command output that broke the template was from this Cisco IOS version:

Cisco IOS Software, C2960 Software (C2960-LANBASEK9-M), Version 12.2(44)SE6, RELEASE SOFTWARE (fc1)
Copyright (c) 1986-2009 by Cisco Systems, Inc.
Compiled Mon 09-Mar-09 18:10 by gereddy

i.e. at least 10 years old. So Cisco didn't change the output format, rather the template was broken by some recent commit.

@FragmentedPacket
Copy link
Contributor Author

@vnetman You're right about the brackets. Updated.

@FragmentedPacket FragmentedPacket merged commit 2fa9ee6 into networktocode:master Nov 11, 2019
@FragmentedPacket FragmentedPacket deleted the fix-537 branch November 11, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco_ios_show_interfaces_switchport.template broken
2 participants