Fixed regex for fortinet bgp template and added new template standards #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
suggested changes
Feb 9, 2020
| @@ -1,9 +1,15 @@ | |||
| Value BGP_NEIGH (\d+?\.\d+?\.\d+?\.\d+?) | |||
| Value NEIGH_AS (\d+) | |||
| Value UP_DOWN (\w+) | |||
| Value UP_DOWN ((?:\w|:)*) | |||
There was a problem hiding this comment.
Would it be worth it to change to \S+ to capture anything non-whitespace? This should hopefully prevent us from having to worry too much about any format changes for it.
| Value STATE_PFXRCD (\w+) | ||
|
|
||
| Start | ||
| ^BGP router identifier.*$$ |
There was a problem hiding this comment.
Do you mind changing the static spaces to \s+?
|
@FragmentedPacket, thank you for your feedback. I have made the requested changes. Please let me know if there's anything else that may need improvement. |
|
@ccorvese Thanks for another contribution! |
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
fortinet_fortios_get_router_info_bgp_summary.textfsmFortinet FortiOSget router info bgp summarySUMMARY
This fixes an issue with some of the output returned from the
get router info bgp summarycommand onfortinet fortios. Sometimes time returned output from the device has ":" in the UP_DOWN portion (i.e. 05:48:47). The previous regex did not account for the ":" character. I have updated that with this PRAdditionally, I have updated the template to account for all potential lines of output from the command, finishing on an error state if a line is presented without a regex match.