Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Template - CISCO IOS - Show Module #593

Merged
merged 13 commits into from
Feb 22, 2020

Conversation

alekgozali
Copy link
Contributor

Added Show Module

ISSUE TYPE
  • New Template Pull Request
COMPONENT

Template : show module
os : cisco_ios
command : show module

SUMMARY

this version added with show module output, textfsm will parse all the output into the dictionary


@alekgozali
Copy link
Contributor Author

Added Show etherchannel summary

@alekgozali alekgozali closed this Feb 13, 2020
@alekgozali alekgozali reopened this Feb 13, 2020
@alekgozali alekgozali changed the title Show_Module CISCO IOS - Show Module & Show Etherchannel Summary Feb 13, 2020
@FragmentedPacket
Copy link
Contributor

@alekgozali We're discussing this internally in regards to the show_module, but in the mean time, do you minding splitting this PR up into individual PRs per template? You can keep all the show_module templates in here, but move out the other two and the necessary data/yaml files as well.

@FragmentedPacket FragmentedPacket added changes_requested Waiting on user to address feedback Internal Review Requested labels Feb 18, 2020
@alekgozali alekgozali changed the title CISCO IOS - Show Module & Show Etherchannel Summary New Template - CISCO IOS - Show Module Feb 19, 2020
@alekgozali
Copy link
Contributor Author

@alekgozali We're discussing this internally in regards to the show_module, but in the mean time, do you minding splitting this PR up into individual PRs per template? You can keep all the show_module templates in here, but move out the other two and the necessary data/yaml files as well.

Hi @FragmentedPacket , i have modified it , only show module added on this PR,
i'm quite new to git and i hope i can contribute more for this ntc-template,
i had prepared few modules ( show mpls ldp neighbour, show mpls interface, show etherchannel summary ) which haven't added yet to this template.
how we can generate .yaml file from .raw ? is there any way to be generated automatically

@FragmentedPacket
Copy link
Contributor

We appreciate any contributions we get!

Here is some scripts developed by @jmcgill298 and are detailed in our README

You can submit each template into their own PRs so we can review and get those merged in sooner as well.

FragmentedPacket and others added 2 commits February 21, 2020 15:27
… were detected, cleaned up regex to not adhere to tabular length
@FragmentedPacket FragmentedPacket merged commit 6fa22d7 into networktocode:master Feb 22, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback Internal Review Requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants