Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add huawei vrp display version #597

Merged
merged 5 commits into from
Feb 24, 2020
Merged

add huawei vrp display version #597

merged 5 commits into from
Feb 24, 2020

Conversation

lutfisan
Copy link
Contributor

@lutfisan lutfisan commented Feb 20, 2020

Huawei VRP - display version - template
  • New Template Pull Request
COMPONENT

huawei_vrp_display_version.textfsm
HUAWEI VRP
display version

SUMMARY

templates/huawei_vrp_display_version.textfsm Show resolved Hide resolved


Start
^.*software,\sVersion\s${VRP_VERSION}\s\(${PRODUCT_VERSION}\)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind changing the each \s to \s+ just in case they change any whitespace between versions and it won't break the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@FragmentedPacket FragmentedPacket added changes_requested Waiting on user to address feedback New Template labels Feb 22, 2020
templates/index Outdated
@@ -1,368 +1,369 @@
# First line is the header fields for columns and is mandatory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert whatever formatting was done on this and just make sure your new template line is the only change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad

@FragmentedPacket FragmentedPacket merged commit 51bdf61 into networktocode:master Feb 24, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback New Template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants