Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Template: hp comware show ip interface #609

Merged
merged 2 commits into from
Mar 8, 2020
Merged

New Template: hp comware show ip interface #609

merged 2 commits into from
Mar 8, 2020

Conversation

sliddjur
Copy link
Contributor

@sliddjur sliddjur commented Mar 4, 2020

ISSUE TYPE
  • New Template Pull Request
COMPONENT

hp_comware_show_ip_interface, hp comware, show ip interface

SUMMARY

Add a new template.

Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value INTF (\S+)
Value LINE_STATUS (.+)
Value PROTOCOL_STATUS (\S+)
Value List IPADDR (\S+)
Value MTU (\d+)


Start
  ^\S+\s+current\s+state -> Continue.Record
  ^${INTF}\s+current\s+state:\s+${LINE_STATUS}
  ^Line\s+protocol\s+current\s+state:\s+${PROTOCOL_STATUS}
  ^Internet\s+Address\s+is\s+${IPADDR}\s+Primary
  ^Internet\s+Address\s+is\s+${IPADDR}\s+Sub
  ^The\s+Maximum\s+Transmit\s+Unit:\s+${MTU}\s+bytes
  ^\s*$$
  ^. -> Error

I would use something more like this. The change of name for the values is to fit and try and keep similar templates the same across vendors. I took the values from cisco_ios_show_ip_interface for this.

The next step would be to account for the other data in the output. By accounting, we don't mean you have the capture it, but just account for it. For example:

  ^input\s+packets
  ^output\s+packets

templates/hp_comware_display_ip_interface.textfsm Outdated Show resolved Hide resolved
@FragmentedPacket FragmentedPacket added changes_requested Waiting on user to address feedback New Template labels Mar 6, 2020
@FragmentedPacket FragmentedPacket merged commit bf33147 into networktocode:master Mar 8, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback New Template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants