Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show band-select template #637

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Conversation

timjsmith24
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_wlc_ssh_show_band-select.textfsm, .*, cisco_wlc_ssh, show band-select

SUMMARY

shows info on band select settings


Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timjsmith24

Would you mind updating the spaces in the template with \s+?

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Apr 15, 2020
@timjsmith24
Copy link
Contributor Author

fixed the spaces in template



Start
^Band\s+Select\s+Probe\s+Response\.*\s${BAND_SELECT_PROBE_RESPONSE}s*$$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some static spacing on all the rule lines \s.

Also, can you change the value regex's to have \s+ as well?

@FragmentedPacket FragmentedPacket merged commit 7b8955c into networktocode:master Apr 15, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants