Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arista_eos_show_interfaces.textfsm #676

Closed
wants to merge 1 commit into from

Conversation

RasmusThing
Copy link

Added support for subinterfaces like Ethernet49/1 for 100GE ports.

Added support for subinterfaces like Ethernet1/49.1 for 100GE ports.
@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label May 3, 2020
@FragmentedPacket
Copy link
Contributor

Do you mind bringing those into the original PRs and then closing out those PRs?

Each PR should include the following files that pertain to an issue/enhancement:

  1. Changes to the template.
  2. New .raw file that includes the raw output from the device and within the correct test directory.
  3. New .yml file that includes the correctly parsed data using the changes from the template and within the correct test directory.

There is an included utility we provide that will parse the .raw file and provide the .yml (development_scripts.py) and more information regarding that can be found in our README. We recommend checking the auto-generated .yml file to make sure it does capture everything appropriately.

If you need help, you can find us on our Network to Code Slack.

@FragmentedPacket
Copy link
Contributor

@Kosire What issue are you having with this? Looking at the raw output you provided in #682, it parses fine except for link_status which is fixed in the PR below.

We can continue discussion on #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants