Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Template: cisco_nxos_show_hsrp_all #760

Merged
merged 2 commits into from
Jun 23, 2020
Merged

New Template: cisco_nxos_show_hsrp_all #760

merged 2 commits into from
Jun 23, 2020

Conversation

network-dave
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

Cisco NXOS - show hsrp all

SUMMARY

Note: some items will stay empty depending on which is the active router.

^\s+Virtual\s+IP\s+address\s+is\s+${PRIMARY_IPV4_ADDRESS}\s+.*$$
^\s+Secondary Virtual IP address is ${SECONDARY_IPV4_ADDRESS}\s*$$
^\s+Active router is ${ACTIVE_ROUTER}\s*$$
^\s+Active router is ${ACTIVE_IP_ADDRESS}\s?, priority ${ACTIVE_PRIORITY} expires in ${ACTIVE_EXPIRE}.*$$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind replacing the static spaces with \s+ all through the template?

Also, I would get rid of the record on whitespace and add the follow right below Start:

Suggested change
^\s+Active router is ${ACTIVE_IP_ADDRESS}\s?, priority ${ACTIVE_PRIORITY} expires in ${ACTIVE_EXPIRE}.*$$
Start
^Vlan -> Continue.Record

Also:

Suggested change
^\s+Active router is ${ACTIVE_IP_ADDRESS}\s?, priority ${ACTIVE_PRIORITY} expires in ${ACTIVE_EXPIRE}.*$$
# Catch unexpected non-empty lines (secondary IP's at the end of the block for example)
^\s+\d+\.\d+\.\d+\.\d+$$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This went under the radar, my bad. Will do ASAP !

Copy link
Contributor Author

@network-dave network-dave Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing whitespaces = done.

^Vlan -> Continue.Record :

This won't work because the interface name can be anything, not only "Vlan". "Continue.Record" at the beginning isn't working either (empty fields are recorded and following data is shifted)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these changes either :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "^Vlan -> Continue.Record" does not work as intended, what do you suggest ? Let me know if you want to discuss this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just leave it as is right now, but push the white space changes up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed the changes to the branch, my bad.

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Jun 12, 2020
@FragmentedPacket FragmentedPacket merged commit fdeea45 into networktocode:master Jun 23, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants