Fixes #790 - new template cisco_nxos_show_environment.textfsm #838
Conversation
scrape SERIAL form show ver, end on -> Error, match all junk in between.
remove extra space at end of capabilities match
enable ^.+ -> Error match
add match for vrf <> to be parsed by same template
add test case for new index match + vrf all
revert IOS XE match but leave SERIAL
revert more of the unneccesary changes leaving only uptime.
add missing newline at end of file
accept review suggestion, match multiple spaces not just one. Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
match multiple spaces not just one. Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
…m to parse new test - still broken mashing two tables.
4tables into one long list, its a mess.
Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
There was a problem hiding this comment.
The only change in the original output now is the addition of Value.
power_supply_input: ""
That is matched in new test template.
This template is still fundamentally broken in mashing together 3 different tables into one. (Power supply's, Fans's, Temperatures)
|
@diepes It appears the second |
make Power supply capture more specific to differentiate between two samples Exclude value captured as unknown fan.
tests/cisco_nxos/show_environment/cisco_nxos_show_environment2.yml |
|
Did you mean to close this? I'll try and review later tonight if you re-open it. Thanks again for all your work into these templates. |
|
no sorry, i thought it was close the reply/request |
New Template - cisco_nxos_show_environment.textfsm (networktocode#838)
Revert "New Template - cisco_nxos_show_environment.textfsm (networktocode#838)"
Removed `cisco_nxos_show_environments.textfsm` as it's not a valid command.
Removed `cisco_nxos_show_environments.textfsm` as it's not a valid command.
ISSUE TYPE
COMPONENT
cisco_nxos
cisco_nxos_show_environments.textfsm (Current broken)
cisco_nxos_show_environment.textfsm (New)
SUMMARY
Fixes #790
Current template "cisco_nxos_show_environments.textfsm" not fixable, notice extra "s" and it tries to extract two tables, Power and Fan from output.
Create new template "cisco_nxos_show_environment.textfsm" that handle old .raw and new #790 output, but only extracts the power table.
Will request from user output of more specific commands to be added as additional templates.
e.g. show environment fan
See: tests/cisco_nxos/show_environments/cisco_nxos_show_environments.yml
vs: tests/cisco_nxos/show_environment/cisco_nxos_show_environment.yml
Same .raw parsed.