-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#788 ios show int fc #839
Merged
FragmentedPacket
merged 5 commits into
networktocode:master
from
diepes:fix#788-ios-show-int-fc
Dec 6, 2020
Merged
Fix#788 ios show int fc #839
FragmentedPacket
merged 5 commits into
networktocode:master
from
diepes:fix#788-ios-show-int-fc
Dec 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
December 5, 2020 07:12
FragmentedPacket
suggested changes
Dec 6, 2020
tests/cisco_ios/show_interfaces_status/cisco_ios_show_interfaces_status2.raw
Show resolved
Hide resolved
Simplify Error match, to just dot. Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
simplify dash line match Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
Changes implemented, new Value FC_MODE, captures the FC mode "NP" in example, not the same as TYPE the L1 - Interface type. |
FragmentedPacket
approved these changes
Dec 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
SUMMARY
Fix's #788
templates/cisco_ios_show_interfaces_status.textfsm
be able to match fc interfaces, and add new {MODE} for fc interfaces.