Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#788 ios show int fc #839

Merged

Conversation

diepes
Copy link
Contributor

@diepes diepes commented Dec 5, 2020

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT
SUMMARY

Fix's #788
templates/cisco_ios_show_interfaces_status.textfsm

be able to match fc interfaces, and add new {MODE} for fc interfaces.


@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Dec 6, 2020
diepes and others added 3 commits December 6, 2020 18:22
Simplify Error match, to just dot.

Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
simplify dash line match

Co-authored-by: Mikhail Yohman <mikhail.yohman@gmail.com>
@diepes
Copy link
Contributor Author

diepes commented Dec 6, 2020

Changes implemented, new Value FC_MODE, captures the FC mode "NP" in example, not the same as TYPE the L1 - Interface type.

Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

@FragmentedPacket FragmentedPacket merged commit 51a6e05 into networktocode:master Dec 6, 2020
@diepes diepes deleted the fix#788-ios-show-int-fc branch December 7, 2020 11:30
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants