Fixes #851 and add new template #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os_show_ip_arp_detail2.raw fix compatability of template templates/cisco_nxos_show_ip_arp_detail.textfsm
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
jmcgill298
reviewed
Feb 26, 2021
…s_show_ip_arp_detail
after matching header, jump to Data section and extract values. Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
simplify match as suggested in pr Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
|
@jmcgill298 please have a look again i think it is all in order now. |
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new test tests/cisco_nxos/show_ip_arp_detail/cisco_nxos_show_ip_arp_detail2.raw
fix compatibility of template templates/cisco_nxos_show_ip_arp_detail.textfsm
ISSUE TYPE
COMPONENT
templates/cisco_nxos_show_ip_arp_detail.textfsm
SUMMARY
add new test, time not just in "00:00:00" format , also in "0.000000" format.
add "&. -> Error" catch and match unused headers.
make time match more specific , looking for 3 types dot, colon, or just dash