Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.4/8 compatibility (OpenMage 20.x) #1256

Merged
merged 78 commits into from
Aug 28, 2023
Merged

PHP 7.4/8 compatibility (OpenMage 20.x) #1256

merged 78 commits into from
Aug 28, 2023

Conversation

cmuench
Copy link
Member

@cmuench cmuench commented Jul 16, 2022 •
edited
Loading

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

Subject: PHP 8.1 compatibility

Fixes #1133
See Checklist: #1275

Changes proposed in this pull request:

  • Upgrade Symfony to 4.4
  • Upgrade PHPUnit to 9.x
  • Supress deprecation warnings (to be compatible with PHP 7.4)
  • Drop support for PHP <7.4
  • Test CI with OpenMage 20.
  • Backport classes from n98-magerun2
  • Optimize code style

@cmuench cmuench marked this pull request as draft July 16, 2022 09:28
This was referenced Nov 20, 2022
Closed
Closed
@colinmollenhour
Copy link

This is a huge PR, kudos for the hard work! Is it in working condition? Anything holding up the merge?

@cmuench
Copy link
Member Author

cmuench commented Jul 19, 2023

@colinmollenhour the installer is broken. If the installer works then we see the test results. My gut feeling is that we will find some minor todos then.
Sadly I have not enough energy to finish the PR.
In the daily business I do work with M1 anymore for years.

@sreichel
Copy link
Collaborator

sreichel commented Jul 20, 2023 •
edited
Loading

@cmuench @colinmollenhour installer is fixed. Sample data needs some work and some unit tests have to be fixed. I've also no time at the moment.

edit: installer works only for OpenMage (???)

@colinmollenhour
Copy link

Perhaps this PR could be merged and tagged in it's current state as 2.4.0-beta1 or 3.0.0-beta1? Would be a shame if this sat unused for a long time..

@cmuench
Copy link
Member Author

cmuench commented Jul 20, 2023

@colinmollenhour @sreichel I just reviewed.
our are right @sreichel. The installer was already fixed.
Currently we have 48 broken tests.
Example job log: https://github.com/cmuench/n98-magerun/actions/runs/5119227073/job/13852779165#step:10:608

@cmuench
Copy link
Member Author

cmuench commented Jul 20, 2023

Perhaps this PR could be merged and tagged in it's current state as 2.4.0-beta1 or 3.0.0-beta1? Would be a shame if this sat unused for a long time..

Some commands seem to be broken. So it's not 100% compatible at the moment.

@sreichel
Copy link
Collaborator

Another problem is that there are no tagged releases for Magento 1.x

@cmuench
Copy link
Member Author

cmuench commented Jul 20, 2023

Another problem is that there are no tagged releases for Magento 1.x

You mean a tag for n98-magerun?

@sreichel
Copy link
Collaborator

No, magento-mirror has no composer installable releases.

So atm it only works for OM. (or did I missed something?)

@sreichel
Copy link
Collaborator

sreichel commented Jul 20, 2023 •
edited
Loading

@colinmollenhour i would not like a release at current state. Seems I've missed one or two commands that can be easily fixed.

UnitTests v9 seems no big deal, but I've no time for.

@cmuench cmuench mentioned this pull request Aug 27, 2023
Merged
2 tasks
@sreichel
Copy link
Collaborator

@cmuench nice :) maybe I've some time during next days.

cmuench and others added 15 commits August 28, 2023 21:59
@cmuench
Supress deprecation warnings
dcef1ba 
We do this, because we also want to stay compatible with
older Magento versions and older PHP versions.
We cannot optimize for PHP 8.1 and stay compatible with PHP 7.2.
@cmuench
Add PHP 8.1 testcase and update ddev setup
d288640 
# Conflicts:
#	.ddev/config.yaml
#	.github/workflows/ci.yml
@cmuench
Add travis job for PHP 8.1
e4205d3 
# Conflicts:
#	.travis.yml
@cmuench
Update dependency for PHP 8.1
a59b1d1 
# Conflicts:
#	composer.lock
@cmuench
Backport TableHelper from n98-magerun2
a02b530
@cmuench
WIP Remove old question helper
dfa451f
@sreichel @cmuench
Update composer packages
6112b57
@sreichel @cmuench
Fixes bootstrap.php
ed153d2
@sreichel @cmuench
Updated commands - replaced DialogHelper
ad39054 
(was removed in symfony3)
@sreichel @cmuench
Update symfony packages to ^5.4
bf4313d
@sreichel @cmuench
Removed MagentoConnect commands
30d6c6b
@sreichel @cmuench
PhpStan fixes
1bfa29e
@sreichel @cmuench
Replaced fzaninotto/faker
e3a1012
@sreichel @cmuench
Added php7.4 support
ff3a611
@sreichel @cmuench
Fixed output for index:reindex
79fab0a
cmuench and others added 25 commits August 28, 2023 22:04
@cmuench
Backport sub command support
86690ff
@cmuench
WIP backport installer
907e3c9 
Composer logic currently does not work for Magento 1 without Composer.

# Conflicts:
#	src/N98/Magento/Command/Installer/InstallCommand.php
@cmuench
Updated config.yaml
84d33d1 
# Conflicts:
#	config.yaml
@sreichel @cmuench
Updated MAGENTO_INSTALL_SCRIPT_PATH
4cf2a5f
@sreichel @cmuench
Test
f097e55
@sreichel @cmuench
Revert "Test"
44260ce 
This reverts commit 185fc0a.
@sreichel @cmuench
Test
00cbf0f
@sreichel @cmuench
Revert "Test"
cc57a50 
This reverts commit 8b4fa85.
@cmuench
Try to fix the installer
4d32ec1
@cmuench
Fix db password parameter and add "skip url validation"
72a737f
@cmuench
Fix some parameters of the installer
5569564
@cmuench
Remove dba entry in ddev config
d8be755
@cmuench
Add n98-magerun logo
46a4004 
[skip ci]

# Conflicts:
#	readme.rst
@cmuench
Compatibility with ddev v1.22.1
1f7746a
@cmuench
Remove unused database util class
433651c
@cmuench
Add sample data installer
c214f09
@cmuench
Update phpunit to v9
d998a54
@cmuench
Replace Dialog with Question Helper
2846d77
@cmuench
First bunch of refactored test (helpers)
21712af
@cmuench
Refactoring the next bunch of tests
aae4c53
@cmuench
Prepare dev release v3.0.0
385fe65
@cmuench
Fix next bunch of tests
cd40ea0
@cmuench
Fix syntax error
aa1a2ba
@cmuench
Fix database helper tests
0dfcf94
@cmuench
MariaDB vs. MySQL (old version?)
b4c81c1
@cmuench cmuench marked this pull request as ready for review August 28, 2023 20:24
@cmuench cmuench merged commit 5ceb822 into netz98:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 7.4/8 support (OpenMage 20.x)
3 participants
@cmuench @colinmollenhour @sreichel