Close rerun.txt file properly after reading the failed features (fixes …

…#20).
netzpirat · Oct 14, 2011 · 9b6966a · 9b6966a
1 parent 2e5cdd5
commit 9b6966a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/guard/cucumber.rb b/lib/guard/cucumber.rb
@@ -110,7 +110,7 @@ def read_failed_features
       failed = []
 
       if File.exist?('rerun.txt')
-        failed = File.open('rerun.txt').read.split(' ')
+        failed = File.open('rerun.txt') { |file| file.read.split(' ') }
         File.delete('rerun.txt')
       end
 

diff --git a/spec/guard/cucumber_spec.rb b/spec/guard/cucumber_spec.rb
@@ -95,7 +95,9 @@
     it 'saves failed features' do
       runner.should_receive(:run).with(['features'], default_options.merge(:message => 'Running all features')).and_return(false)
       File.should_receive(:exist?).with('rerun.txt').and_return true
-      File.stub_chain(:open, :read).and_return 'features/foo'
+      file = mock('file')
+      file.should_receive(:read).and_return 'features/foo'
+      File.stub(:open).and_yield file
       File.should_receive(:delete).with('rerun.txt')
       expect { guard.run_all }.to throw_symbol :task_has_failed
 
@@ -203,7 +205,9 @@
 
     context 'with a rerun.txt file' do
       before do
-        File.stub_chain(:open, :read).and_return 'features/foo'
+        file = mock('file')
+        file.stub(:read).and_return 'features/foo'
+        File.stub(:open).and_yield file
       end
 
       it 'keeps failed spec and rerun later' do