Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report javascript errors that prevent specs from running. #123

Merged
merged 1 commit into from
Apr 6, 2013

Conversation

swistak
Copy link
Contributor

@swistak swistak commented Apr 6, 2013

This solution is a bit hackish. But allows us to forward console output
and errors from javascript to test runner.

There can be multiple errors, and each of them will get reported.

Also specs will be marked as failed which gives correct error status for CI

@swistak
Copy link
Contributor Author

swistak commented Apr 6, 2013

I've reworked solution to be completelly on side of javascript. Does not break tests anymore. But only reports one error.

@swistak
Copy link
Contributor Author

swistak commented Apr 6, 2013

Travis reports build as failed becouse it failed on rbx in 1.9 mode (dunno why, but master also fails). Other platforms passed.

@netzpirat netzpirat merged commit e431dcc into guard:master Apr 6, 2013
@netzpirat
Copy link
Contributor

This is great! Thanks a lot. I know that there are currently some problems with Rubinius, but I'm unsure what the problem is and I can't even install Rubinius on my local machine to investigate at the moment. Hope I can fix it next week and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants