Fix detect a directory as the phantomjs executable #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`File.executable?(exe)` will return `true` for directories. This patch ensures that only files are selected. With the existing code, it can detect a directory named `phantomjs` as the phantomjs executable. This was exactly what was happening in my case: Sencha Cmd tool creates a "phantomjs" directory which is reachable from the path, and this was making guard-jasmine fail.
|
Thanks a lot! 1.19.2 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.executable?(exe)will returntruefor directories. This patch ensures that only files are selected.With the existing code, it can detect a directory named
phantomjsas the phantomjs executable. This was exactly what was happening in my case: Sencha Cmd tool creates a "phantomjs" directory which is reachable from the path, and this was making guard-jasmine fail.