Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page always failing when iframes are being used #19

Merged
merged 1 commit into from Dec 15, 2011
Merged

Fix page always failing when iframes are being used #19

merged 1 commit into from Dec 15, 2011

Conversation

obrie
Copy link
Contributor

@obrie obrie commented Dec 14, 2011

When the page being loaded by run-jasmine.coffee (the main jasmine page) contains specs that load iframes, each of those iframes triggers the phantomjs page's onLoadFinished callback. This can cause problems where the jasmine page loads successfully but some of the iframes that get generated by specs fail. When this happens, you get the following error:

Unable to access Jasmine specs at http://127.0.0.1:8888/

To fix this, the onLoadFinished handler for the page is reset after the first time its called. This first status result is a guarantee that jasmine loaded successfully. All further calls to that callback can be ignored.

This is potentially an issue that should be fixed in phantomjs, but we can at least get a workaround in guard-jasmine until then.

…oid cases where the page uses iframes which also trigger the callback
@netzpirat netzpirat merged commit 4302944 into guard:master Dec 15, 2011
@netzpirat
Copy link
Contributor

Thank you for your contribution. I can imagine that it took quite some time to recognize what the problem was and how to fix it. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants