Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse methods variants with parentDir don't respect custom charset #44

Closed
netzwerg opened this issue Nov 14, 2017 · 1 comment
Closed

Parse methods variants with parentDir don't respect custom charset #44

netzwerg opened this issue Nov 14, 2017 · 1 comment
Assignees
@netzwerg
Labels
bug
Milestone
0.13.2

Comments

@netzwerg
Copy link
Owner

After #43 not all methods actually respect the provided charset.

Namely

Parser.csv(Schema schema, File parentDir)
Parser.tsv(Schema schema, File parentDir)

still always use UTF-8.
@netzwerg netzwerg added the bug label Nov 14, 2017
@netzwerg netzwerg added this to the 0.13.2 milestone Nov 14, 2017
@netzwerg netzwerg self-assigned this Nov 14, 2017
netzwerg added a commit that referenced this issue Nov 14, 2017
@netzwerg
#44: Parse methods with parentDir param now also respect custom charsets
82c6a17
@netzwerg
Copy link
Owner Author

netzwerg commented Jan 8, 2018

Fixed in 0.13.2

@netzwerg netzwerg closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netzwerg netzwerg

Labels
bug
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
1 participant
@netzwerg