-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN Release 1.0.2 #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug report issues template
merge initial code into local
Initial setup
* remove httr import (#4) * spelling/grammar updates and capitalization consistency * ready for cran submission
* enhance openxlsx handling to allow user to save workbooks * bugfix * dev version bump * ready for CRAN submission
* bugfix - dynamically created tables didn't hide/show the download button properly. Due to a conflict between hide/show() and setting display:none initially. * test fix * v0.4.5 cran release prepped
…#10) htmltools 0.4.0 comparability for tests
* downloadFile xlsx rownames (#11) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * downloadableTable selection of rows (#14) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * add selection parameter * doc * force update if the same selection is provided * simplify * move selection argument for backwards compatibility add manual test to check selection of rows in downloadableTable module * remove manual test * fix single select (#15) * fix single select * shinydashboardPlus integration (#13) * remove httr import * downloadable table: add support for displaying rownames * simplify * remove column name for rownames column * update version number * add option to add rownames to downloadable xlsx file * fix item not found * refactor * initial shinydashboardplus integration * fix layout * dynamic right sidebar * update * updates * replace table by fluidRow * styling * update example * add documentation * revert fix * update documentation, add right sidebar content * update example * process review comment * add reset button argument update right sidebar functionality * update documentation/formatting * rename right_sidebar to rightsidebar * rename * rename reset to resetbutton * documentation * fix single select * documentation/formatting updates * undo 7dca316 * releasing 0.4.7 to CRAN
* update roxygen * update conversion * add_reset_button function * add tests * downloadFile: add option to show/hide rownames (#20) * add option to disable row.names in csv/tsv * push version * test updates, optional sidebar tabs (#21) * use tmp dir for conversion functions testing * New Feature - if the user only uses the Advanced Tab * refactoring * fix overwriting files R 3.4 * update shiny min version * readying for CRAN submission * comments for cran sub * spelling
* Check reactive class value using `inherits` * Use `shiny::is.reactive()` instead of `inherits()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.