Update Held-Suarez forcing to support model parallelism. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_660470844
branch
from
c517ade to
d049e5e
Compare
copybara-service
bot
force-pushed
the
test_660470844
branch
2 times, most recently
from
3b4b923 to
94dcd0f
Compare
This small update should enable model parallelism with Held-Suarez forcing -- the velocity tendencies should be a tuple, not an array with a leading dimension of size 2. I've updated the documentation and type annotations of DiagnosticState.cos_lat_u to match. xref: #45 TODO: write a unit test to verify that running Held-Suarez with model parallelism works. PiperOrigin-RevId: 660522143
copybara-service
bot
force-pushed
the
test_660470844
branch
from
94dcd0f to
8dae3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Held-Suarez forcing to support model parallelism.
This small update should enable model parallelism with Held-Suarez forcing -- the velocity tendencies should be a tuple, not an array with a leading dimension of size 2. I've updated the documentation and type annotations of DiagnosticState.cos_lat_u to match.
xref: #45
TODO: write a unit test to verify that running Held-Suarez with model parallelism works.