Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SphericalHarmonics implementations #56

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Nov 4, 2024

Consolidate SphericalHarmonics implementations

  • Delete ComplexSphericalHarmonics
  • Replace the old RealSphericalHarmonics with RealSphericalHarmonicsWithZeroImag, which is what we actually use in practice (it's faster and supports parallelism)

@copybara-service copybara-service bot changed the title No public description Consolidate SphericalHarmonics implementations Nov 4, 2024
@copybara-service copybara-service bot force-pushed the test_693112634 branch 15 times, most recently from 8b2020e to ff78eac Compare November 7, 2024 22:27
- Delete ComplexSphericalHarmonics
- Replace the old RealSphericalHarmonics with RealSphericalHarmonicsWithZeroImag, which is what we actually use in practice (it's faster and supports parallelism)

PiperOrigin-RevId: 694250875
@copybara-service copybara-service bot merged commit 11981a1 into main Nov 7, 2024
@copybara-service copybara-service bot deleted the test_693112634 branch November 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant