Fix uninitialized variable in quantized compressors #205
Conversation
There was a problem hiding this comment.
Thank you for your contribution @markmc! Indeed you made a good catch, these variables are uninitialized in some cases.
Thank you for including test cases as well. The tests are useful to illustrate when this error occurs, but I agree with you in that they are highly artificial. Since they are so artificial, I think we should avoid merging the test cases into main, but keep your bug fixes under src.
Once those changes have been made, I'd be happy to help get this merged in. Thanks again! 🙂
Both compressors have a can_quantize() check, which if ever doesn't succeed would trigger: > UnboundLocalError: cannot access local variable 'quantized_weight' where it is not associated with a value
markmc
force-pushed
the
unbound-variable
branch
from
ce81191 to
eeb01b1
Compare
No problem, I've dropped the tests 👍 |
Both compressors have a
can_quantize()check, which if ever doesn't succeed would trigger:Add the obvious fix for this and highly artificial test cases that would trigger it.
Looks like this error was introduced by #109
Definitely begs the question whether this code path has any real world use!