Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loguru, not logging module #212

Closed
wants to merge 1 commit into from
Closed

Use loguru, not logging module #212

wants to merge 1 commit into from

Conversation

horheynm
Copy link
Member

Convert from logging module to loguru.
Loguru deps dont have conflict or adds any ML-specific libraries that will collide.

Copy link
Contributor

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This adds loguru as a dependency to vllm, so we should briefly verify that vllm + this branch of CT does not have any dependency conflicts.

@kylesayrs
Copy link
Contributor

We should probably bound the version of loguru to prevent against upstream vulnerabilities

@horheynm
Copy link
Member Author

Ok good point. loguru is helpful on our side, but this repo is for vllm inference.
I can map which part of vllm uses what part of compressed_tensors. but its best not to add extra dependencies.
vllm doesnt use loguru

Ill close this for now

@horheynm horheynm closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants