Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rs/logging example #796

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Rs/logging example #796

wants to merge 21 commits into from

Conversation

robertgshaw2-neuralmagic
Copy link
Contributor

  • Simple Example Connecting DeepSparse Logging To Prometheus

Copy link
Contributor

@dbogunowicz dbogunowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few nits, otherwise really great job. I really love the use case and the README.md. Feels super intuitive, albeit exhaustive!

Copy link
Contributor

@Beth-Kosis Beth-Kosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a wrap-up of some sort?

@@ -0,0 +1,230 @@
# DeepSparse + Prometheus/Grafana

This is a simple example that shows you how to connect DeepSparse Logging to the Prometheus/Grafana stack.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is a simple example that shows you how to connect DeepSparse Logging to the Prometheus/Grafana stack.
This is a simple example that shows you how to connect DeepSparse logging to the Prometheus/Grafana stack.


This is a simple example that shows you how to connect DeepSparse Logging to the Prometheus/Grafana stack.

#### There are four steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### There are four steps:
There are four steps:

This is a simple example that shows you how to connect DeepSparse Logging to the Prometheus/Grafana stack.

#### There are four steps:
- Configure DeepSparse Logging to log metrics in Prometheus format to a REST endpoint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Configure DeepSparse Logging to log metrics in Prometheus format to a REST endpoint
1. Configure DeepSparse logging to log metrics in Prometheus format to a REST endpoint.


#### There are four steps:
- Configure DeepSparse Logging to log metrics in Prometheus format to a REST endpoint
- Point Prometheus to the appropriate endpoint to scrape the data at a specified interval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Point Prometheus to the appropriate endpoint to scrape the data at a specified interval
2. Point Prometheus to the appropriate endpoint to scrape the data at a specified interval.

#### There are four steps:
- Configure DeepSparse Logging to log metrics in Prometheus format to a REST endpoint
- Point Prometheus to the appropriate endpoint to scrape the data at a specified interval
- Run the client script simulating a data quality/drift issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Run the client script simulating a data quality/drift issue
3. Run the client script simulating a data quality/drift issue.


So, in our case, the `url` section should be: `http://172.18.0.2:9090`.

Click `Save & Test`. We should get a green check saying "Data Source Is Working".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Click `Save & Test`. We should get a green check saying "Data Source Is Working".
Click `Save & Test`. We should get a green check indicating, "Data Source Is Working."


Click `Save & Test`. We should get a green check saying "Data Source Is Working".

#### Import A Dashboard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Import A Dashboard
#### Importing a Dashboard


Now you should be ready to create/import your dashboard.

Grafana's interface for adding metrics is very intuitive (and you can use PromQL),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Grafana's interface for adding metrics is very intuitive (and you can use PromQL),
Although Grafana's interface for adding metrics is very intuitive (and you can use PromQL),

Now you should be ready to create/import your dashboard.

Grafana's interface for adding metrics is very intuitive (and you can use PromQL),
but we have provided a simple pre-made dashboard for this use case.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
but we have provided a simple pre-made dashboard for this use case.
we have provided a simple pre-made dashboard for this use case.

Grafana's interface for adding metrics is very intuitive (and you can use PromQL),
but we have provided a simple pre-made dashboard for this use case.

Click `Dashboard` -> `Import` on the left-hand side bar. You should see an option to upload a file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Click `Dashboard` -> `Import` on the left-hand side bar. You should see an option to upload a file.
Click `Dashboard` -> `Import` on the left-hand sidebar. You should see an option to upload a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants