This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Dyn per token varun cleanup #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,29 +20,47 @@ | |||
| #include "cuda_compat.h" | |||
|
|
|||
| namespace vllm { | |||
|
|
|||
There was a problem hiding this comment.
Hey @bnellnm - I made some C++ interface changes to this file - Can you please take a look. Thanks.
dsikka
approved these changes
May 7, 2024
dsikka
pushed a commit
that referenced
this pull request
May 14, 2024
Description: - Remove inline asm for float to int8 conversion - Refactor reduction utils to add blockReduceMax --------- Co-authored-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
dsikka
pushed a commit
that referenced
this pull request
May 24, 2024
Description: - Remove inline asm for float to int8 conversion - Refactor reduction utils to add blockReduceMax --------- Co-authored-by: Varun Sundar Rabindranath <varun@neuralmagic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: