This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the groundwork for separating the "serving" and "throughput" benchmarks into separate UI pages/etc. Their data will persist in subfolders of the existing
dev/bench
folder of thenm-gh-pages
branch, and they will have their own separate UI pages. We can easily put a simpleindex.html
page indev/bench
which has links to these separate pages.With these changes, the currently executed
benchmark_serving
results will be present at theserving
subfolder and the upcomingbenchmark_thoughput
results will be in athroughput
subfolder:benchmark_serving
: https://neuralmagic.github.io/nm-vllm/dev/bench/serving/benchmark_throughput
: https://neuralmagic.github.io/nm-vllm/dev/bench/throughput/One thing I’d like improved is how the separate files are handled in the
BENCHMARK-RESULT
job in.github/workflows/nm-benchmark.yml
. Since you cannot use amatrix
strategy within a step, I opted in the short term for duplicating the steps so that, similar to the existing process, each potential results file will have its own step guarded by theif
prop. I could likely make the entire job use amatrix
strategy, however, I’d be concerned about the potential of merge conflicts/etc. arising if multiple jobs are trying to push to thenm-gh-pages
branch too close to each other.Additionally:
pip install
output during therun benchmarks
action into a collapsed-by-default group (screenshot below), which can be clicked to expand and will auto-expand if you use the GitHub UI “Search logs” textbox:.github/actions/nm-github-action-benchmark/action.yml
– thetype
prop is not valid inside an action (it’s mostly to guide the UI and typically only value forworkflow_dispatch
input definitions).