Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependabot/fetch-metadata from 1.4.0 to 1.5.0 #648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: metadata
id: metadata
if: github.actor == 'dependabot[bot]'
uses: dependabot/fetch-metadata@v1.4.0
uses: dependabot/fetch-metadata@v1.5.0
with:
github-token: ${{ steps.generate_token.outputs.token }}
- name: Enable auto-merge for bot PRs
Expand Down
18 changes: 10 additions & 8 deletions tests/unit/test_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -652,21 +652,23 @@ async def test_get_latest_value_unknown_instance_type(
self,
collector_factory: Callable[..., AbstractContextManager[GCPNodePriceCollector]],
) -> None:
with collector_factory("n1-highmem-8", "unknown", True) as collector:
with pytest.raises(AssertionError, match=r"Found prices only for: \[\]"):
await collector.get_latest_value()
with collector_factory(
"n1-highmem-8", "unknown", True
) as collector, pytest.raises(
AssertionError, match=r"Found prices only for: \[\]"
):
await collector.get_latest_value()

async def test_get_latest_value_unknown_gpu(
self,
collector_factory: Callable[..., AbstractContextManager[GCPNodePriceCollector]],
) -> None:
with collector_factory(
"n1-highmem-8-1xv100", "n1-highmem-8", True
) as collector:
with pytest.raises(
AssertionError, match=r"Found prices only for: \[CPU, RAM\]"
):
await collector.get_latest_value()
) as collector, pytest.raises(
AssertionError, match=r"Found prices only for: \[CPU, RAM\]"
):
await collector.get_latest_value()


class TestAzureNodePriceCollector:
Expand Down