Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cypress support function 'loadAppState' #332

Closed
jarmoza opened this issue Jan 31, 2023 · 5 comments · Fixed by #405
Closed

Refactor Cypress support function 'loadAppState' #332

jarmoza opened this issue Jan 31, 2023 · 5 comments · Fixed by #405
Assignees
@jarmoza @rmanaem
Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Jan 31, 2023

Moving on to the annotation page, there is one more support function being used for the pages tests that needs to be refactored: loadAppState. This makes reference to several old Vuex actions and may need to be reworked for new logic/removals in the new Vuex store.
@jarmoza jarmoza added annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Jan 31, 2023
@jarmoza jarmoza self-assigned this Jan 31, 2023
@jarmoza jarmoza mentioned this issue Jan 31, 2023
Closed
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 3, 2023
@surchs
Copy link
Contributor

surchs commented Mar 21, 2023

@jarmoza I removed the old "Blocked" status because I want to remove that attribute. Can you check that this issue is indeed not blocked - and otherwise move it to the new "tracked" status, please.

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 22, 2023
@jarmoza
Copy link
Contributor Author

jarmoza commented Mar 22, 2023 •
edited
Loading

Sure. This is being worked on currently. So 'Implement - Active' is now appropriate.

@jarmoza
Copy link
Contributor Author

jarmoza commented Apr 4, 2023

Blocked by #386

@rmanaem rmanaem assigned jarmoza and rmanaem and unassigned jarmoza Apr 13, 2023
@rmanaem rmanaem mentioned this issue Apr 17, 2023
Merged
@rmanaem rmanaem linked a pull request Apr 17, 2023 that will close this issue
Refactored e2e tests #405
Merged
@jarmoza
Copy link
Contributor Author

jarmoza commented Apr 25, 2023

Closed by #405

@jarmoza jarmoza closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarmoza jarmoza

@rmanaem rmanaem

Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored e2e tests neurobagel/annotation_tool
3 participants
@surchs @jarmoza @rmanaem