Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored e2e tests #405

Merged
merged 10 commits into from
Apr 25, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Apr 17, 2023

This PR contains:

  • Refactor of Cypress support function loadAppState
  • Refactor of annotation-pagtests.cy.js
  • Refactor of simple-e2etests.cy.js
  • Re-enabling the refactored tests in the e2e workflow

Closes #332 #333 #341

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Congrats @rmanaem and @jarmoza on getting us back to green on the end to end tests. That's a big milestone 🎉 !

I mostly have 🍒 in the comments, but there are a couple of leftover debug statements I think you should take out. I also noted a couple of places where a clarifying comment will save a reader some time in understanding why a particular thing is done in the tests.

store/index.js Show resolved Hide resolved
pages/annotation.vue Outdated Show resolved Hide resolved
pages/annotation.vue Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
cypress/e2e/page/annotation-pagetests.cy.js Outdated Show resolved Hide resolved
cypress/e2e/page/annotation-pagetests.cy.js Show resolved Hide resolved
cypress/e2e/app/simple-e2etest.cy.js Show resolved Hide resolved
cypress/e2e/app/simple-e2etest.cy.js Show resolved Hide resolved
cypress/e2e/app/simple-e2etest.cy.js Show resolved Hide resolved
cypress/e2e/app/simple-e2etest.cy.js Outdated Show resolved Hide resolved
@jarmoza
Copy link
Contributor

jarmoza commented Apr 19, 2023

I'm assuming @rmanaem will handle change requests here from @surchs, but if needed - given I did work on this as well - I can make requested changes for resubmission.

@rmanaem rmanaem requested a review from surchs April 25, 2023 14:09
@jarmoza
Copy link
Contributor

jarmoza commented Apr 25, 2023

@surchs / @rmanaem I will be creating a new branch for the next-page component tests as it turned out not to be relevant for the issue we were facing in closing out this PR. I just submitted a commit to clean up the remaining debug messages. @surchs Can you approve for merge?

@rmanaem
Copy link
Contributor Author

rmanaem commented Apr 25, 2023

@jarmoza Have you made any changes to the code since my last commit?

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmanaem and @jarmoza. Looks good. I left a suggestion and a request for either removing or explicitly skipping instead of commenting out the page tests.

cypress/e2e/app/simple-e2etest.cy.js Show resolved Hide resolved
cypress/e2e/page/annotation-pagetests.cy.js Outdated Show resolved Hide resolved
@jarmoza jarmoza merged commit be37a6b into dev_components_talk_to_store_directly Apr 25, 2023
@jarmoza jarmoza deleted the jarmoza-e2e-refactor branch April 25, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants