Annotation tool now outputs JSON files reflecting the annotated table #163
Conversation
There was a problem hiding this comment.
Yay 🎉. Awesome milestone @jarmoza! We definitely need to celebrate this!
I think this is something you should consider demonstrating to the group on Thursday. Then we can also see how this sprint-release demo thing works for us.
To the PR: tried it out, confirmed it works! I think there is a bit of code duplication going on in the download.vue page but that's alright for now. Would still suggest to add a flag so we'll find it again during refactor!
Otherwise all looks great to me, let's go ahead and merge this!
|
|
||
| return `${this.datasetName}_annotated_${Date.now()}.json`; | ||
| }, | ||
|
|
There was a problem hiding this comment.
Just wanted to say: very nice and clean stuff going on here! 🎉
| saveAs(blob, this.defaultOutputFilename); | ||
| }, | ||
|
|
||
| refreshCategoryToColumnMap() { |
There was a problem hiding this comment.
I'm pretty sure this is a duplicate from elsewhere in the app, no?
Let's at least add a // TODO flag or something like it so we don't forget to refactor this!
There was a problem hiding this comment.
No, this is in fact a method to create/refresh a reverse of the column to category map in the store. categoryToColumnMap is a local object only used by the download page. Made sense to update it in some way in case a user altered the columnToCategoryMap in the store.
Instead of putting a watch on columnToCategoryMap, I elected to make the refresh happen upon component mounted.
Let me know if you have an implementation suggestion around that though!
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Primary changes:
<original data table tsv filename>_annotated_<current timestamp>.jsonOther related changes:
Filenames of data table and data dictionary files are stored in the store after upload on the landing page
Fix for getter
getColumnOfCategory-->getColumnsOfCategorycloses Create JSON output of annotated input data #162