Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explanation component test added #219

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Explanation component test added #219

merged 2 commits into from
Nov 7, 2022

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 1, 2022

  • added component test to illustrate prop behavior minor refactoring:
  • use uuid package to ensure random ID instead of passing unique ID as prop
  • minor refactor of variable names

closes #211

@surchs
Explanation component test added
4a65be8 
- added component test to illustrate prop behavior
minor refactoring:
- use uuid package to ensure random ID instead of passing unique ID as prop
- minor refactor of variable names

closes #211
@surchs surchs requested a review from jarmoza November 1, 2022 02:15
jarmoza
jarmoza suggested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small change requests. Otherwise, feel free to rebase afterwards!

components/annot-explanation.vue Outdated Show resolved Hide resolved
cypress/component/annotation-explanation.cy.js Outdated Show resolved Hide resolved
@surchs
Style changes
ffa74f9 
- single -> double quotes in test
- uiText element to be consistent with other components
@surchs
Copy link
Contributor Author

surchs commented Nov 7, 2022

@jarmoza, I worked in both of your comments. If you're good, I'd merge this one with a squash commit because the style stuff doesn't need to be in the history.

jarmoza
jarmoza approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @surchs! Go for the squash merge.

@surchs surchs merged commit a416600 into dev_components_talk_to_store_directly Nov 7, 2022
@surchs surchs deleted the annotation_tool-211 branch November 7, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmoza jarmoza jarmoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surchs @jarmoza