Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored annot-categorical component so it's ready for the store #241

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Dec 2, 2022

Fixes #213
Deprecates: annot-discrete-choices and annot-vocabulary components

@rmanaem rmanaem self-assigned this Dec 2, 2022
@rmanaem rmanaem changed the base branch from master to dev_components_talk_to_store_directly December 2, 2022 20:52
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR @rmanaem 🎉. I have made only one comment for the description of one of the tests. With that, I think this is good to go! 🎉

cypress/component/annot-categorical.cy.js Outdated Show resolved Hide resolved
surchs and others added 2 commits December 5, 2022 11:36
- refactored the component to get the data directly from the store
- has missing value button

Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
- annot-discrete-choices.vue
- annot-vocabulary.vue
- removed annot-discrete-choices.cy.js test component
- functionality now exists in annot-categorical vue component

Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
@rmanaem rmanaem merged commit 43a71f6 into dev_components_talk_to_store_directly Dec 5, 2022
@rmanaem rmanaem deleted the surchs-213 branch December 5, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specify annot-categorical component
2 participants