Refactor annotation-tab component #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a component test. Not clear what to test here, since this no longer has any UI elements - just make sure it mounts for now
- prop (pased from parent page) to set own category (activeCategory) - store getter to get the correct annotation component for the activeCategory - tests to assert over both inputs being understood right
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took over this PR from @jarmoza because this component was the last small component to be refactored (rest are pages and I/O things)
Note: the component tests are visually empty because the
annot-tabcomponent is just a container component for the components displayed on the annotation page.The component now has no internal logic or state because it's child components talk directly to the store. The only thing it is passing along is the prop for the
activeCategory.Closes #207