Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of nextPageAccessible getter #258

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Removal of nextPageAccessible getter #258

merged 1 commit into from
Dec 14, 2022

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Dec 14, 2022

Upon review, it's apparent that the nextPageAccessible getter can be removed from the store and its usage in the next-page component.

This same functionality can be accessed by calling getter pageAccessible with the return value of getter nextPage as an argument.

@jarmoza jarmoza requested a review from surchs December 14, 2022 16:36
@jarmoza jarmoza added feat:consolidate Merging existing features for simplification. global interface labels Dec 14, 2022
@jarmoza jarmoza changed the base branch from master to dev_components_talk_to_store_directly December 14, 2022 16:37
surchs
surchs approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jarmoza: cool, looks good to me.

@jarmoza jarmoza merged commit e10272f into dev_components_talk_to_store_directly Dec 14, 2022
@jarmoza jarmoza deleted the next-page-update branch December 14, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
feat:consolidate Merging existing features for simplification.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @surchs