-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example data #27
Example data #27
Conversation
- addresses part of #10
@jarmoza: let me know where you were thinking these files should go. |
@jarmoza: thanks for the points.
I think that's where this PR would put them. Let me know if you think a different place is better
Yes, I noticed this too. Not quite sure why, at least some of these files should exist. Will check my downloading code. |
I think two things were happening here:
So I removed the participant.json files that don't exist, and added the ones that do. I think a lot of "real world" BIDS datasets come without the participants.json data dictionary. I am not sure that we should support these cases because it'll probably make our lives harder. But I'll leave them in for now since we also have examples with data dictionaries |
@surchs Looks good now. As for whether or not we want to support datasets without a participants.json file, we should decide that. For now, I already have logic built into my incoming PR that allows for just using a participants.tsv file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still getting used to the reviewing system. All looks good!
Added some examples for participants.tsv data and (most of) the corresponding json sidecar files. All of the files are real data from openneuro (hence the ds dataset IDs).
(mostly) closes #10