-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page file loading, Clickable columns on Categorization Page, and Vuex Store #28
Conversation
…factoring for child file selector component
… TSV files specifically.
…columns on categorization page; Working Vuex store (see commit notes for further details)
…ization table components
awesome! Thanks @jarmoza for this PR! |
@surchs Can you attach here the tsv file you were using? |
Make the new example files available
@jarmoza I used this example file but I think you can use any .tsv file with more than one column to reproduce. I merged master into this branch to make these files available for testing for you. |
@surchs Okay! I had to look in reverse in order to see what the issue was. There's nothing wrong with your file. There was something wrong with my test file(s) – which were apparently using spaces instead of tabs. The JS library I'm using to parse the file is apparently primarily built for csv files. So I'll have to figure out another solution for these tsv files. Stay tuned... |
d3 seems to have things for this: |
@surchs Thanks. I considered that. In fact, the current solution with papaparse produces correct data from the tsv file. There's actually just a processing error occurring in my file selector and store code. Fixing that now. |
…papaparse for tsv files.
…neuro/annotation_tool into columnpage-clickablecolumns
Alright, confirmed this works. That's great stuff @jarmoza! We're getting there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jarmoza, I think this looks very good. I vote to merge this.
|
||
// 4. Change the background and foreground colors of the clicked list group item | ||
|
||
// A. Color the clicked list group item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with these indices for comments. Do they have a structure or meaning? Are they reflecting some flow-control hierarchy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bulleting system for commenting steps and substeps of a piece of code.
0 - I use for setup
1-n Primary steps
A-Z Substeps for primary steps
I, II, III, etc. for Subsubsteps
a-z for subsubsubsteps
i, ii, iii, etc. subsubsubsubsteps (if we ever really get that low)
"Diagnosis", | ||
"Assessment Tool" | ||
], | ||
backgroundColors: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to set a global colormap somewhere else in case we end up reusing colors on other pages?
e.g. if we decided to color each section of the annotation page based on the color applied here (e.g. age as purple)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could list that in the store.
<textarea :rows="fileTextLines" cols="300"> | ||
{{ this.fileText.join("\n") }} | ||
</textarea> | ||
<h2>JSON File</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this Data dictionary
for now. Later we'll add some explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will be added in the a forthcoming PR.
Landing page and Categorization page now have initial functionality working
Supporting components include:
a. the file-selector (landing page)
b. coloring-listgroup (listbox on categorization page), and
c. the filedata-table (table on categorization page).
Issues addressed: