Implemented mutation to change column to category mapping #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mutation changes the mapping of an already mapped column to a different category Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Mutation: - removes the mapping of column to category if they're already mapped - changes the mapping of column to category if they're not already mapped
Component reflects the changes following the implementation of alterColumnCategoryMapping mutation
Component and its test reflect the changes following the implementation of alterColumnCategoryMapping mutation
Component and its test reflect the changes following the implementation of alterColumnCategoryMapping mutation
6 tasks
Removed `{key: "category"}` field
surchs
requested changes
Dec 16, 2022
There was a problem hiding this comment.
Very cool PR @rmanaem 🎉, thank you! Thanks also for fixing that little extra column thing in the column-linking-table, I think I had missed that.
Everything looks good, I left some comments to point out things I think you left over from debugging. And I think the store mutation either needs a docstring or a slightly clearer argument name for the category - or maybe both.
With these changes: good to go!
edit: also: very cool that our cypress runner just picks up the new unit tests! Eventually we could look into having those run as part of their own action!
- removed dead code and comments in components - uncommented columnToCategoryMapping object in store state - changed activeCategory to targetCategory in alterColumnCategoryMapping mutation - added docstring for alterColumnCategoryMapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #252