-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented mutation to change column to category mapping #283
Conversation
The mutation changes the mapping of an already mapped column to a different category Co-authored-by: Sebastian Urchs <surchs@users.noreply.github.com>
Mutation: - removes the mapping of column to category if they're already mapped - changes the mapping of column to category if they're not already mapped
Component reflects the changes following the implementation of alterColumnCategoryMapping mutation
Component and its test reflect the changes following the implementation of alterColumnCategoryMapping mutation
Component and its test reflect the changes following the implementation of alterColumnCategoryMapping mutation
Removed `{key: "category"}` field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool PR @rmanaem 🎉, thank you! Thanks also for fixing that little extra column thing in the column-linking-table
, I think I had missed that.
Everything looks good, I left some comments to point out things I think you left over from debugging. And I think the store mutation either needs a docstring or a slightly clearer argument name for the category - or maybe both.
With these changes: good to go!
edit: also: very cool that our cypress runner just picks up the new unit
tests! Eventually we could look into having those run as part of their own action!
- removed dead code and comments in components - uncommented columnToCategoryMapping object in store state - changed activeCategory to targetCategory in alterColumnCategoryMapping mutation - added docstring for alterColumnCategoryMapping
closes #252