-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented getColumnNames getter #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rmanaem. This all looks very good. However #291 has implemented essentially the same getter (minus the tests and component fixes). So I think we should have a chat with @jarmoza on how to proceed with this.
My sense is that we can probably merge #291 without implementing this getter, but for the moment I would wait for us to chat :).
Yea, I saw Jonathan's PR and comment on #255 when working on this so I replaced my implementation with his to avoid unnecessary conflicts. If I recall correctly he also wrote a test for the
I also think we should remove(or move) the |
@rmanaem I agree and will remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 good to go! 👀
Also added "lint-fix" command to package.json file
- Removed lint-fix and added back husky install that was deleted by accident in package.json file - Removed the left over debug statement from column-linking-table.cy.js - Fixed the indentation in store-getter-getColumnNames.cy.js
Closes #255