Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setCurrentPage mutation + unit test for store refactor #296

Merged
merged 1 commit into from
Jan 6, 2023
Merged

setCurrentPage mutation + unit test for store refactor #296

merged 1 commit into from
Jan 6, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Jan 5, 2023 •
edited
Loading

This is a straightforward implementation for both the mutation and test. The mutation itself is currently only used by the tool-navbar and the next-page components.

This addresses #265

@jarmoza jarmoza changed the base branch from master to dev_components_talk_to_store_directly January 5, 2023 20:25
@jarmoza jarmoza requested a review from rmanaem January 5, 2023 20:26
rmanaem
rmanaem approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jarmoza! Good to go 👍🏼

@jarmoza jarmoza merged commit e39b34a into dev_components_talk_to_store_directly Jan 6, 2023
@jarmoza jarmoza deleted the jarmoza-265 branch January 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @rmanaem