-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank annotation for mockup image #33
Conversation
Awesome @jarmoza, thanks a lot! I'll check it out |
@jarmoza I commented out the |
@surchs The translateY part is purely for aesthetics to center the image vertically. It's not a block. Feel free to merge if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one question about stylesheet placement. Otherwise I think this is good to go @jarmoza
|
||
</script> | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense for the css to live in its own corner of the project? I'm worried that if each page has a stylesheet section it may become tricky to keep them in sync. This is just for demo now, but "nothing is as permanent as a temporary solution" (someone, probabably)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global styles can be stored and made accessible using this addition to the nuxt.config.js file. See: https://nuxtjs.org/docs/configuration-glossary/configuration-css/#style-extensions
Typically I would tend to list global styles in a file like that and local ones per component if they are not going to be used elsewhere.
In Vue, the latter is accomplished by including the 'scoped' keyword as a boolean attribute in the style tag. (https://vue-loader.vuejs.org/guide/scoped-css.html) Otherwise, any style defined in a component file is considered global – and yes, can be initially confusing if referenced elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@surchs We can go ahead and adopt that change if you want. We'll make a global css file in the assets/css folder.
@surchs For Friday's demo. Just drop an image in the assets folder and enter its name in the mockupImage.filename variable in the data object in annotation.vue