Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank annotation for mockup image #33

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Feb 3, 2022

@surchs For Friday's demo. Just drop an image in the assets folder and enter its name in the mockupImage.filename variable in the data object in annotation.vue

@jarmoza jarmoza requested a review from surchs February 3, 2022 20:47
@surchs
Copy link
Contributor

surchs commented Feb 3, 2022

Awesome @jarmoza, thanks a lot! I'll check it out

@surchs
Copy link
Contributor

surchs commented Feb 4, 2022

@jarmoza I commented out the transform: translateY(50%) section to have the screenshot sit up top. We can revise that before we merge if you'd like

@jarmoza
Copy link
Contributor Author

jarmoza commented Feb 8, 2022

@surchs The translateY part is purely for aesthetics to center the image vertically. It's not a block. Feel free to merge if you want.

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question about stylesheet placement. Otherwise I think this is good to go @jarmoza


</script>

<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for the css to live in its own corner of the project? I'm worried that if each page has a stylesheet section it may become tricky to keep them in sync. This is just for demo now, but "nothing is as permanent as a temporary solution" (someone, probabably)

Copy link
Contributor Author

@jarmoza jarmoza Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global styles can be stored and made accessible using this addition to the nuxt.config.js file. See: https://nuxtjs.org/docs/configuration-glossary/configuration-css/#style-extensions

Typically I would tend to list global styles in a file like that and local ones per component if they are not going to be used elsewhere.

In Vue, the latter is accomplished by including the 'scoped' keyword as a boolean attribute in the style tag. (https://vue-loader.vuejs.org/guide/scoped-css.html) Otherwise, any style defined in a component file is considered global – and yes, can be initially confusing if referenced elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surchs We can go ahead and adopt that change if you want. We'll make a global css file in the assets/css folder.

@jarmoza jarmoza merged commit b15b17f into master Feb 10, 2022
@surchs surchs deleted the annotation-with-mockup-slot branch February 18, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants