-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting e2e tests + support code for Phase 1 store refactor #330
Adjusting e2e tests + support code for Phase 1 store refactor #330
Conversation
…-refactor-adjustments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jarmoza! Very cool moment to see the app actually come back to life after all this refactoring 🎉! All looks good to me, ready to merge. I left two comments more out of curiosity. Depending on your answer for the index-page test one, I would maybe make the comment for the "click data-dictionary button" step a bit clearer regarding ("why cannot we just assert that this label-button thing is not clickable here")
edit:
Oh, forgot an important point: now that the e2e tests can (at least in principle) pass again, should we exclude the annotation page e2e tests until they are reasonably passing? The goal would be to have from now and going forward fully green tests again!
This PR addresses #309, #310, and #311.
309 - refactor page test setup
loadTestDataIntoStore
to account for new store actions for the data table and dictionary as well as the now-required order for file selection (data table -> data dictionary).commitToNuxtStore
to address the need to set the current page when programmatically routing between annotation tool pages. More on that below.assertNextPageAccess
as it is no longer used in any e2e tests. (With the refactor, the annotation page will no longer have UI elements with their own 'next' buttons – where this test functionality was used.)310 - adjust index page tests
311 - adjust categorization page tests
setCurrentPage
is now called after routing to the categorization page has been done. Without this direct call, the tool believed the current page to still be the home page after the first call tocy.visit('/')
and errored in showing what looked to be the enabled next page button for the home page. (ThecurrentPage
store field is now only set when a navbar item or next page button is clicked on, so mutationsetCurrentPage
needed to be called as part of a programmatic navigation.)