Build static #335
Build static #335
Conversation
Commented out client-only tag in the annotation.vue page. This tag was added as a workaround for a previous bug. It seems to not be needed anymore. It will be fully removed once the current refactor is completed
Added static build target and routing for GH pages according to these docs https://nuxtjs.org/deployments/github-pages/
To push to GH pages
To enable pushing to GH pages
We now use a custom domain so we don't need it anymore fingers crossed
There was a problem hiding this comment.
@surchs Looks good. I just tested out the app. Very cool that this can exist statically.
All of the functionality seems to work with the exception of diagnosis annotation - where there is some wonkiness in some columns not getting annotated or getting wiped after being re-annotated.
Might be worth a brief looking into as I don't recall this problem in the master build.
|
Do you mean like this: #128 ? |
|
No. Apologies for being unclear where this is happening. I mean on the Download page. I had tried annotating for all categories just now (Subject ID, Age, Sex, Diagnosis (Group and GroupDX), Assessment Tools (1 group with IQ). I was seeing one and then both of the Diagnosis columns being completely clear. Retrying just now I believe I see where the bug is, however. It's when the Diagnosis category has its annotations saved more than once. This is the result on the download page.
All that said, I think this is a new-ish bug (similar to #176). I also note that the behavior of the 'Save Annotation' button is inconsistent across tabs (Does it gray out when saved to indicate a save has occurred or does it stay green?). I have filed issues for these two things. (See #339 and #340.) I'm going to go ahead and approve this PR for merge. |
|
Ah yeah, I think #176 is the better fit, agreed. That said: I think we encountered this behaviour/bug before and discussed that it will be resolved together with the larger refactor. If you think this is a new bug, then we should take another look, but not very urgently as the underlying codebase will (mostly) be replaced once the refactor branch merges. |
This PR sets up the master branch for deployment on GH pages and to use a custom domain https://annotate.neurobagel.org
Most steps are just direct from the docs: https://nuxtjs.org/deployments/github-pages/
I did some extra things: