New mutation setHeuristic for phase 2 store refactor #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoza
added
annotation page
maint:refactor
surchs
reviewed
Feb 2, 2023
|
|
||
| dataDictionary: { | ||
| annotated: { | ||
| column1: { transformationHeuristic: "" } |
There was a problem hiding this comment.
minor point: in the default state of the store.state the transformationHeuristic attribute doesn't exist for a column.
That makes sense, not every column will need one, so probably best not to create the field by default.
However: it would be good to have a test here that checks that we actually successfully create the attribute as well.
i.e.:
- mock the state to not have
transformationHeuristic(i.e. to reflect the default state), - fire the mutation
- ensure that 1) the respective column now does have the
transformationHeuristicattribute, and 2) that the value of this attribute is correct
There was a problem hiding this comment.
@surchs Makes sense. One moment.
There was a problem hiding this comment.
@surchs Okay. Just added the existence check as well. Check it out and see what you think.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #270.
setHeuristicis now a mutation that takes a column and heuristic name and assigns the heuristic to thetransformationHeuristicfield in the data dictionary object for that columnsetHeuristicmutation.annot-continuous-valuescomponent has been amended to understandsetHeuristicas a mutation instead of an action.