Refactor getter 'getAnnotationComponent' #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoza
added
annotation page
maint:refactor
surchs
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Looks good @jarmoza ! You have a checkbox for depending components have been checked and are calling this mutation correctly on the issue, is there any component that needs to change its ways to play nice with this getter?
Otherwise good to go 🎉 !
|
Thanks @surchs. Currently looking into why the |
|
As per #347 , full testing of getters like |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #267.
There is now a getter to retrieve what was once
specializedComponentin theannotationDetailslist in the store.Now the
componentName(currentlyannot-continuous-valuesorannot-categorical) is listed alongside each category in thecategoriesobject.This implementation is accompanied by 3 unit tests for the current categories that are operative on the annotation page: 'Age' (continuous values), 'Sex' and 'Diagnosis' (categorical). There is currently no component for the 'Subject ID' category as this requires no annotation.