Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation 'changeMissingStatus' for Phase 2 Store Refactor #359

Merged
merged 11 commits into from
Feb 16, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Feb 15, 2023

This PR closes #275 by implementing the following:

  1. A mutation changeMissingStatus that takes a column name, value, and a boolean flag indicating whether or not the value should be marked as missing or its missing status should be removed.
  2. A unit test for changeMissingStatus in store-mutation-changeMissingStatus.cy.js that tests adding and removing the missing status of a value.
  3. Previous uses of the functions designateAsMissing and declareAsNotMissing in annot-categorical and annot-missing-values have been converted into using the more general changeMissingStatus mutation.
  4. An unused reference to designateAsMissing in the test for annot-continuous-values (ostensibly for a future 'mark as missing' feature for this component) has been amended for the new mutation name and parameters.

@jarmoza jarmoza added annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Feb 15, 2023
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me @jarmoza 🎉

store/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!
I left two comments, one for adding a comment as a reminder I leave up to you and the other for whether missingValues should exist in store state.

@jarmoza jarmoza merged commit eb926c9 into dev_components_talk_to_store_directly Feb 16, 2023
@jarmoza jarmoza deleted the jarmoza-275 branch February 16, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants