-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutation 'changeMissingStatus' for Phase 2 Store Refactor #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good to me @jarmoza 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
I left two comments, one for adding a comment as a reminder I leave up to you and the other for whether missingValues
should exist in store state.
This PR closes #275 by implementing the following:
changeMissingStatus
that takes a column name, value, and a boolean flag indicating whether or not the value should be marked as missing or its missing status should be removed.changeMissingStatus
instore-mutation-changeMissingStatus.cy.js
that tests adding and removing the missing status of a value.designateAsMissing
anddeclareAsNotMissing
inannot-categorical
andannot-missing-values
have been converted into using the more generalchangeMissingStatus
mutation.designateAsMissing
in the test forannot-continuous-values
(ostensibly for a future 'mark as missing' feature for this component) has been amended for the new mutation name and parameters.