-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getUniqueValues getter for Phase 2 Store Refactor #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmanaem
reviewed
Feb 17, 2023
rmanaem
reviewed
Feb 17, 2023
rmanaem
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the PR @jarmoza! The unit-test test is thorough and in-line comments are nice and helpful. I left two comments that simply address the type of uniqueValues
mentioned in the in-line comments other than that It's good to go!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #277 by implementing the following:
getUniqueValues
getter in the store that takes every column linked to a given category and gathers unique values for each column via thedataTable
. The getter outputs an object keyed on column with values that are an array of the unique values for that column. Missing values are skipped via lookup in thedataDictionary
getUniqueValues
also takes an optional parametermaxValues
to limit how many values are returneddisplayItems
in theannot-categorical
component has been rewritten to accommodate the new output ofgetUniqueValues
store-getter-getUniqueValues.cy.js
test the following scenarios: a) unique values for a single column, b) unique values for multiple columns, c) retrieving unique values with the optional maximum amount argument, and d) ensuring that no 'missing' values are returned with the unique values