Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changeMissingStatus getter Fix + Check for Unique Values #365

Merged
merged 2 commits into from
Feb 17, 2023
Merged

changeMissingStatus getter Fix + Check for Unique Values #365

merged 2 commits into from
Feb 17, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Feb 16, 2023 •
edited
Loading

This PR closes #171 and #364 by implementing the following:

  1. Ensuring missing values are added/removed from the missingValues list that will exist for each column in dataDictionary.annotated
  2. Add a uniqueness check to the add value case in changeMissingStatus
  3. Updating unit tests for checkMissingStatus to properly add/remove from missingValues lists
  4. Additional unit test to ensure no duplicate values can be added to the missingValues list in dataDictionary.annotated.<column>.

@jarmoza jarmoza added annotation page bug:functional Functional defects resulting from feature changes. feat:improve Incremental, user facing improvements of an existing feature. labels Feb 16, 2023
@jarmoza jarmoza requested review from rmanaem and removed request for rmanaem February 16, 2023 20:52
@jarmoza jarmoza marked this pull request as draft February 16, 2023 20:53
@jarmoza jarmoza requested a review from rmanaem February 16, 2023 20:54
@jarmoza jarmoza marked this pull request as ready for review February 16, 2023 20:54
rmanaem
rmanaem approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@jarmoza jarmoza merged commit 5c8ab88 into dev_components_talk_to_store_directly Feb 17, 2023
@jarmoza jarmoza deleted the jarmoza-171-364 branch February 17, 2023 17:31
This was referenced Feb 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
annotation page bug:functional Functional defects resulting from feature changes. feat:improve Incremental, user facing improvements of an existing feature.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @rmanaem